Skip to content

test(watch): verify the banner precedes polling output - #1295

Merged
unhappychoice merged 1 commit into
masterfrom
factory/implement-3977264f
Nov 21, 2026
Merged

unhappychoice merged 1 commit into
masterfrom
factory/implement-3977264f

Conversation

@unhappychoice

Copy link
Copy Markdown
Member

Extend the polling spec to let the worker emit step headings and logs before returning control to BuildWatcher#start. Assert that the banner identifies the project and build number before any of that output. The existing implementation already prints the banner before launching the worker.

Verified on Ruby 3.4.13 with bundle exec rubocop lib and COVERAGE=true bundle exec rspec (351 examples, 0 failures). Temporarily reversing the startup order made the focused spec fail on the output order as expected.

Closes #1276

🤖 Opened by factory

@unhappychoice unhappychoice added factory:change A pull request opened by the factory factory:merge labels Nov 21, 2026
@unhappychoice
unhappychoice merged commit 7a40ad8 into master Nov 21, 2026
6 checks passed
@unhappychoice
unhappychoice deleted the factory/implement-3977264f branch November 21, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

factory:change A pull request opened by the factory factory:merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Print the watch banner before starting the polling thread

1 participant