Skip to content

fix: read all remaining bytes when finalizing watch logs - #1294

Merged
unhappychoice merged 1 commit into
masterfrom
factory/implement-15b40d9a
Nov 21, 2026
Merged

unhappychoice merged 1 commit into
masterfrom
factory/implement-15b40d9a

Conversation

@unhappychoice

Copy link
Copy Markdown
Member

Use HTTP 206 Content-Range to determine when a watch log is complete. During finalization, request each remaining range from the next unread byte and preserve the incomplete-output warning if retries cannot reach the advertised end.

Regression tests verify that the second request starts at byte 3 and produces a single abcdef line, that finalization drains more than two ranges, and that missing bytes trigger a warning.

Verified with bundle exec rspec (354 examples, 0 failures), bundle exec rubocop lib (36 files, no offenses), and git diff --check.

Closes #1274

🤖 Opened by factory

@unhappychoice unhappychoice added factory:change A pull request opened by the factory factory:merge factory:needs-decision Waiting for a human decision and removed factory:merge factory:needs-decision Waiting for a human decision labels Nov 21, 2026
@unhappychoice
unhappychoice merged commit 9a57d1f into master Nov 21, 2026
6 checks passed
@unhappychoice
unhappychoice deleted the factory/implement-15b40d9a branch November 21, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

factory:change A pull request opened by the factory factory:merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Read all remaining bytes when finalizing watch logs

1 participant