Repository navigation
fix: read all remaining bytes when finalizing watch logs - #1294
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use HTTP 206 Content-Range to determine when a watch log is complete. During finalization, request each remaining range from the next unread byte and preserve the incomplete-output warning if retries cannot reach the advertised end.
Regression tests verify that the second request starts at byte 3 and produces a single
abcdefline, that finalization drains more than two ranges, and that missing bytes trigger a warning.Verified with
bundle exec rspec(354 examples, 0 failures),bundle exec rubocop lib(36 files, no offenses), andgit diff --check.Closes #1274
🤖 Opened by factory