Skip to content

fix(watch): retry transient final build detail failures - #1292

Merged
unhappychoice merged 1 commit into
masterfrom
factory/implement-e12ec81d
Nov 21, 2026
Merged

unhappychoice merged 1 commit into
masterfrom
factory/implement-e12ec81d

Conversation

@unhappychoice

Copy link
Copy Markdown
Member

Retry the final build-detail request once for the same transient network errors handled by live polling. Keep step processing, log output, and completion messages outside the retry scope. If both requests fail, propagate the final error.

Regression tests verify that a timeout followed by success reports completion once and starts the next eligible build, that a persistent timeout stops after two attempts, and that a timeout during step processing does not trigger another detail request. The command-level regression test reproduces the timeout when the retry is disabled.

bundle exec rubocop lib passed. COVERAGE=true bundle exec rspec passed all 353 examples on Ruby 3.4.13 and 3.3.14.

Closes #1273

🤖 Opened by factory

@unhappychoice unhappychoice added factory:change A pull request opened by the factory factory:merge factory:needs-decision Waiting for a human decision and removed factory:merge labels Nov 21, 2026
@unhappychoice
unhappychoice merged commit 0e881ca into master Nov 21, 2026
6 checks passed
@unhappychoice
unhappychoice deleted the factory/implement-e12ec81d branch November 21, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

factory:change A pull request opened by the factory factory:needs-decision Waiting for a human decision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Retry transient build-detail failures when finishing watch

1 participant