Repository navigation
fix(watch): retry transient final build detail failures - #1292
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retry the final build-detail request once for the same transient network errors handled by live polling. Keep step processing, log output, and completion messages outside the retry scope. If both requests fail, propagate the final error.
Regression tests verify that a timeout followed by success reports completion once and starts the next eligible build, that a persistent timeout stops after two attempts, and that a timeout during step processing does not trigger another detail request. The command-level regression test reproduces the timeout when the retry is disabled.
bundle exec rubocop libpassed.COVERAGE=true bundle exec rspecpassed all 353 examples on Ruby 3.4.13 and 3.3.14.Closes #1273
🤖 Opened by factory