Skip to content

fix(watch): handle Pusher connection failures - #1289

Merged
unhappychoice merged 2 commits into
masterfrom
factory/implement-ac084816
Nov 21, 2026
Merged

unhappychoice merged 2 commits into
masterfrom
factory/implement-ac084816

Conversation

@unhappychoice

Copy link
Copy Markdown
Member

Pass Pusher connection-thread exceptions to the watch loop through a thread-safe queue while preserving the existing pusher:error event. The watch command reports the cause on stderr and exits with status 1 through the existing subscription cleanup path.

The regression test starts with a successful empty build-list fetch and account lookup, then fails the connection thread while watch is waiting. It verifies the error message, exit status, unsubscribe, and disconnect.

Verified with COVERAGE=true bundle exec rspec on Ruby 3.3.14 and 3.4.13 (338 examples, 0 failures on each), bundle exec rubocop --no-parallel --cache false lib, and git diff --check.

Closes #1271

🤖 Opened by factory

@unhappychoice unhappychoice added factory:change A pull request opened by the factory factory:merge factory:needs-decision Waiting for a human decision factory:fix and removed factory:merge factory:needs-decision Waiting for a human decision labels Nov 21, 2026
…-request-a3228a20

# Conflicts:
#	lib/circleci/cli/command/watch_command.rb
@unhappychoice
unhappychoice merged commit aa8b619 into master Nov 21, 2026
6 checks passed
@unhappychoice
unhappychoice deleted the factory/implement-ac084816 branch November 21, 2026 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

factory:change A pull request opened by the factory factory:merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle Pusher connection failures in the watch loop

1 participant