Repository navigation
fix(watch): handle Pusher connection failures - #1289
Merged
Merged
Conversation
…-request-a3228a20 # Conflicts: # lib/circleci/cli/command/watch_command.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass Pusher connection-thread exceptions to the watch loop through a thread-safe queue while preserving the existing
pusher:errorevent. The watch command reports the cause on stderr and exits with status 1 through the existing subscription cleanup path.The regression test starts with a successful empty build-list fetch and account lookup, then fails the connection thread while
watchis waiting. It verifies the error message, exit status, unsubscribe, and disconnect.Verified with
COVERAGE=true bundle exec rspecon Ruby 3.3.14 and 3.4.13 (338 examples, 0 failures on each),bundle exec rubocop --no-parallel --cache false lib, andgit diff --check.Closes #1271
🤖 Opened by factory