Repository navigation
fix: preserve HTTP status for unexpected run error bodies - #1287
Merged
Merged
Conversation
…-request-a2fafb55 # Conflicts: # lib/circleci/cli/command/run_command.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check that the nested
errorvalue is an object before reading its fields. Use the first non-blank string fromdetailortitle, and fall back to the HTTP status when neither is usable.Add regression tests for a string-valued
erroron HTTP 502 and for an emptydetailwith a usabletitle. The 502 regression checks the exact stderr output and a nonzero exit status. Both tests failed against the original implementation and passed with the fix.Verified with
bundle exec rubocop libon Ruby 3.4.13 andCOVERAGE=true bundle exec rspecon Ruby 3.4.13 and 3.3.14. All 339 examples passed on both versions.Closes #1269
🤖 Opened by factory