Repository navigation
Conversation
Signed-off-by: woniush <woniushan@yeah.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reject negative column values in
CharStream::translateLineColumnToPosition()before converting the column tosize_t.For
"ABC\nDEF",(line=1, column=-1)currently returns position3because the unsigned addition wraps around. Negative values are invalid according to theLineColumndocumentation. This PR adds a regression test for that case.The affected function body was compiled and checked before and after the change: the result changed from
3tostd::nullopt. The fullsoltestsuite was not run locally because Boost headers and initialized submodules are unavailable in this checkout.Checklist
AI Disclosure