Repository navigation
HDDS-16805. Verify peer chunk checksums during container reconciliation - #11903
Open
andyhuangdev wants to merge 3 commits into
Open
andyhuangdev wants to merge 3 commits into
andyhuangdev wants to merge 3 commits into
Conversation
Always enable checksum verification when reading peer data for reconciliation. Add a regression test covering a corrupt peer followed by a healthy peer with client checksum verification disabled. Validation: all 18 TestContainerReconciliationWithMockDatanodes tests pass; repository checkstyle and git diff --check pass.
andyhuangdev
marked this pull request as ready for review
November 2, 2026 08:12
adoroszlai
reviewed
Nov 12, 2026
adoroszlai
left a comment
adoroszlai
left a comment
Contributor
There was a problem hiding this comment.
Thanks @andyhuangdev for the patch, LGTM.
smengcl
approved these changes
Nov 13, 2026
smengcl
left a comment
smengcl
left a comment
Contributor
There was a problem hiding this comment.
lgtm. Thanks @andyhuangdev
Contributor
@andyhuangdev please re-enable workflows in your fork |
adoroszlai
reviewed
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Container reconciliation now always verifies checksums when reading chunks from a peer, regardless of the datanode’s ozone.client.verify.checksum setting.
Previously, disabling this setting allowed reconciliation to copy corrupt peer data and mark it healthy in the local Merkle tree. A subsequent healthy peer could not repair that chunk during the same task, and the final scan could mark the replica UNHEALTHY.
The change enables checksum verification on the configuration passed to the reconciliation stream, following the existing EC reconstruction approach. Corrupt chunks are rejected before being written, allowing reconciliation to repair the replica from another peer.
What is the link to the Apache JIRA
HDDS-16805
How was this patch tested?
Added a regression test with client checksum verification disabled, a corrupt peer with stale scan results, and a healthy peer. The test failed before the fix and now verifies that reconciliation restores healthy data and leaves the replica CLOSED.
All 18 tests in TestContainerReconciliationWithMockDatanodes pass. Repository checkstyle and git diff --check also pass.