Repository navigation
Conversation
…alues()` Since #4280, `AsyncLogger` calls `updateThreadValues()` again for the `UNCACHED` thread name strategy: although a translator is only used by the thread that created it, the name and priority of that thread can change. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
| private String traceFlags; | ||
|
|
||
| // Due to the usage pattern of this class, these are effectively final | ||
| // Refreshed by `updateThreadValues()`, since the thread name and priority can change |
Contributor
There was a problem hiding this comment.
The Javadoc of updateThreadValues() already says why these change. Can we drop this comment?
Suggested change
| // Refreshed by `updateThreadValues()`, since the thread name and priority can change |
| type="changed"> | ||
| <issue id="4467" link="https://github.com/apache/logging-log4j2/pull/4467"/> | ||
| <description format="asciidoc"> | ||
| Remove the deprecation of `RingBufferLogEventTranslator.updateThreadValues()`. |
Contributor
There was a problem hiding this comment.
Can we use this shorter line?
Suggested change
| Remove the deprecation of `RingBufferLogEventTranslator.updateThreadValues()`. | |
| Undeprecate `RingBufferLogEventTranslator.updateThreadValues()`. |
Contributor
|
The Javadoc now matches what |
ramanathan1504
added
async
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4280, answering the review question left open there.
#3171 deprecated
RingBufferLogEventTranslator.updateThreadValues()and removed its only call, because a translator is only used by the thread that created it. The name and priority of that thread can still change, which is what theUNCACHEDthread name strategy is about, so #4280 restored the call inAsyncLogger, but kept the method deprecated.This PR removes the deprecation and fixes the Javadoc and the field comment that described the thread values as effectively final.
This only concerns
2.x: the deprecation stays on2.25.xand2.26.x.🤖 Generated with Claude Code