Repository navigation
Fix quadratic complexity in HTML pattern escaping - #4461
Merged
ramanathan1504 merged 5 commits intoNov 7, 2026
Merged
Conversation
Contributor
|
The |
ramanathan1504
added
bug
…ttern/EncodingPatternConverterTest.java Co-authored-by: Ramanathan Muthu <ramanathanbscmca@gmail.com>
Contributor
|
The changelog entry is still missing. Can you add it in |
ramanathan1504
added
java
ramanathan1504
approved these changes
Nov 7, 2026
ramanathan1504
left a comment
ramanathan1504
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution
ramanathan1504
approved these changes
Nov 7, 2026
ramanathan1504
left a comment
ramanathan1504
left a comment
Contributor
There was a problem hiding this comment.
Pushed the removal of the unused Timeout import so spotless:check passes.
ramanathan1504
enabled auto-merge (squash)
November 7, 2026 15:18
github-project-automation
Bot
moved this from Approved
to Merged
in Log4j pull request tracker
ramanathan1504
added a commit
that referenced
this pull request
Nov 9, 2026
* Fix quadratic complexity in HTML pattern escaping --------- Co-authored-by: Ramanathan <ramanathan@apache.org> (cherry picked from commit df5fee4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4460.
HTML escaping in
EncodingPatternConverterusedStringBuilder.replacefor each special character, shifting the rest of the buffer each time. This made escaping inputs with many special characters quadratic. This change writes escape sequences in place and adds a test for a large input.Testing:
mvn -pl log4j-core-test -am '-Dtest=EncodingPatternConverterTest' '-Dsurefire.failIfNoSpecifiedTests=false' test— passed.