Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the Ubuntu 24.04 C++ CI image update that installs Node.js 22 before Azurite.
No open issues 🎉
What changed in this PR
Updates the Ubuntu 24.04 C++ CI image to install Node.js 22 before Azurite, addressing Azurite startup failures in the ASAN/UBSAN sanitizer job.
Changes:
- Installs Node.js 22 using
npx --yes n 22. - Adds a comment explaining the version requirement and Ubuntu 24.04’s older default.
| File | Description |
|---|---|
ci/docker/ubuntu-24.04-cpp.dockerfile |
Installs Node.js 22 before Azurite to support its runtime requirements. |
Review effort: Balanced
Member
Author
|
The C++ / AMD64 Ubuntu 24.04 C++ ASAN UBSAN (pull_request) is now successful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Currently the C++ / AMD64 Ubuntu 24.04 C++ ASAN UBSAN is failing.
What changes are included in this PR?
Install node 22 so azurite starts.
Are these changes tested?
Yes, I've validated locally via:
And is tested on CI
Are there any user-facing changes?
No
Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
AI was used for log analysis and possible solutions.
Reviewed before submission by: