Repository navigation
ci(rust): build before testing so the dummy driver can be loaded - #5030
Open
edgarrmondragon wants to merge 1 commit into
Open
edgarrmondragon wants to merge 1 commit into
edgarrmondragon wants to merge 1 commit into
Conversation
Cargo 1.100's new build directory layout no longer places cdylibs on the library search path during `cargo test`, so the exported dummy driver tests fail to find libadbc_dummy. Running `cargo build` first uplifts the cdylib into the target directory, which is on the search path (rust-lang/cargo#8311). Locating the cdylib from Cargo's JSON messages would let `cargo test` work on its own, but that requires the tests to invoke Cargo themselves (`cargo build --message-format=json`), which seemed like more than this needs. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
edgarrmondragon
marked this pull request as ready for review
November 13, 2026 06:18
edgarrmondragon
requested review from
kou,
lidavidm,
wjones127 and
zeroshade
as code owners
November 13, 2026 06:18
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cargo 1.100's new build directory layout no longer places cdylibs on the library search path during
cargo test, so the exported dummy driver tests fail to find libadbc_dummy. Runningcargo buildfirst uplifts the cdylib into the target directory, which is on the search path (rust-lang/cargo#8311).Locating the cdylib from Cargo's JSON messages would let
cargo testwork on its own, but that requires the tests to invoke Cargo themselves (cargo build --message-format=json), which seemed like more than this needs.I noticed this failing in another PR: https://github.com/apache/arrow-adbc/actions/runs/43370376029/job/131704477304?pr=5029
For context, from the 1.100 release notes1:
Assisted-by: Claude Opus 5.5 noreply@anthropic.com
Footnotes
https://doc.rust-lang.org/stable/releases.html#:~:text=Cargo%20now%20uses%20a%20new%20directory ↩