Repository navigation
🐛 match only real subdomains in linker isDomainMatch_ default - #40572
Open
mrdevel2002-ui wants to merge 1 commit into
Open
mrdevel2002-ui wants to merge 1 commit into
mrdevel2002-ui wants to merge 1 commit into
Conversation
With no destinationDomains, isDomainMatch_ fell back to '*' + highestAvailableDomain, which isWildCardMatch compiles to ^.*example\.com$ and so also matched lookalike registrable domains such as evilexample.com, appending linker IDs to links pointing there.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a linker config leaves out
destinationDomains,isDomainMatch_falls back to[highestAvailableDomain, '*' + highestAvailableDomain], andisWildCardMatchturns*example.cominto^.*example\.com$, so separately registrable lookalikes likeevilexample.comornot-example.commatch too. That is the path the linker docs' own example takes (proxyOnly: false, nodestinationDomains) and the one AMP cache pages hit withamp-cookie-scope, so a link or amp-form target on the page pointing at an attacker-registered lookalike gets the linker param appended on click, which for GA is_glcarrying the user's_gaclient ID. Prefixing the wildcard with*.keeps every real subdomain matching (the bare domain is still the first entry) and lines up with the*.example.comform the docs describe; the default-subdomain test now also covers a lookalike host and a nested subdomain.