Repository navigation
[DataTable] One object per column for value, display and format - #11252
Closed
HenriRabalais wants to merge 4 commits into
Closed
HenriRabalais wants to merge 4 commits into
HenriRabalais wants to merge 4 commits into
Conversation
Contributor
|
If we are to refactor this component so much, could it also be converted to Typescript? I can volunteer for review. |
Collaborator
Author
|
@MaximeBICMTL thanks, and appreciate the offer! I think the TypeScript conversion is its own PR though, since it's separate from the column change here. To me it feels like an entirely new set of work. |
This was referenced Oct 28, 2026
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DataTable fields can now define their own cells. A field takes
value,displayandformatfunctions that read off the row's record:valueis what filtering matches against,displayis the text the CSV and sorting use, andformatis what the cell shows, falling back todisplay. DataTable wraps the<td>.A field without these goes through
getFormattedCellandgetMappedCellas before, so the other modules are unchanged.All four biobank tables use the new fields. Each column is defined in one place, and candidates are found through a lookup by PSCID built once per render instead of a search for each cell.
Changes
value,displayandformatto DataTable fields.DataTable.d.ts.Testing Instructions
Related Issues
Resolves #11251
This touches the same render loop as #10285, so whichever merges second will need a rebase.