Repository navigation
Detect versions reported as both affected and fixed - #2499
Open
Prachi194agrawal wants to merge 1 commit into
Open
Prachi194agrawal wants to merge 1 commit into
Prachi194agrawal wants to merge 1 commit into
Conversation
Signed-off-by: Prachi Agrawal <prachi194agrawal@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2324
An advisory can report the same package version as both affected and fixed. For example, the npm advisory for
express-restify-mongooselists version3.0.0in both categories.This PR adds a step to the advisory ToDo pipeline to detect these conflicts within an individual advisory, including across impacts for the same package. It creates a curation ToDo containing the conflicting versions and leaves their status for a human curator to decide.
The change also avoids duplicate version entries in curation details and supports displaying package types without a registered version range scheme.
Testing
Added a fixture based on the reported npm advisory and tests for conflicting and distinct versions, conflicts across impacts, repeated runs, excluded and non-latest advisories, and curation details.
Result: 22 passed, 47 warnings.
