Repository navigation
Flag advisory commits not reachable from repository branches - #2497
Open
Prachi194agrawal wants to merge 1 commit into
Open
Prachi194agrawal wants to merge 1 commit into
Prachi194agrawal wants to merge 1 commit into
Conversation
Signed-off-by: Prachi Agrawal <prachi194agrawal@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #2367
Some advisory commit references do not belong to a branch in the referenced repository. This change keeps those commits and their advisory links while flagging their branch reachability for review.
The
collect_ref_fix_commits_v2pipeline now checks collectedPackageCommitPatchrecords and stores one of three statuses:reachable,unreachable, orunknown. Incomplete clones and failed checks produceunknown. Unreachable commits are highlighted on the advisory commit details page and included in pipeline logs for upstream review.The check creates one temporary bare clone per repository per run, with a five-minute timeout. The status reflects the branches observed during the latest check. This PR records the result locally; reporting commits upstream remains a separate step.
A migration adds the reachability field, with
unknownas the default for existing records. The changes also add documentation and regression tests using local Git repositories.Testing
Result: 22 passed, 5 warnings.
