You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Fix macOS alert sounds from audio shortcuts in the subtitle grid - #762
When a key misses the Subtitle Grid context but matches Audio, the first lookup leaves Skip() set. The command runs, but wxWidgets still treats the event as unhandled, causing a system beep on macOS.
Clear the flag when hotkey::check() consumes an event, including the invalid-command error path. No shortcut changes are needed.
Validation: the fix was previously built and manually tested on macOS with default shortcuts, where the playback keys no longer produced the system alert. The existing 376 C++ tests and LuaJIT compatibility check passed during that validation.
I think this would be cleaner if there was a single evt.Skip(false) at the top of the hotkey::check() function rather than before the two returns?
(Even then the semantics of how hotkey::check skips events are kind of messy when it's called multiple times, but fixing that would make the caller code more complicated, so that's probably fine for now.)
Thanks for the suggestion! Moved evt.Skip(false) to the start of hotkey::check() and removed the two branch-local calls in 654d251. The unmatched-key path still calls evt.Skip(), so unhandled keys continue to propagate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #761.
When a key misses the Subtitle Grid context but matches Audio, the first lookup leaves
Skip()set. The command runs, but wxWidgets still treats the event as unhandled, causing a system beep on macOS.Clear the flag when
hotkey::check()consumes an event, including the invalid-command error path. No shortcut changes are needed.Validation: the fix was previously built and manually tested on macOS with default shortcuts, where the playback keys no longer produced the system alert. The existing 376 C++ tests and LuaJIT compatibility check passed during that validation.