Repository navigation
fix: Box the BigDecimal values in the Postgres proxy row conversion - #3254
Closed
pedrocicoleme wants to merge 1 commit into
Closed
pedrocicoleme wants to merge 1 commit into
pedrocicoleme wants to merge 1 commit into
Conversation
sea-query 1.0 stores Value::BigDecimal as Option<Box<BigDecimal>>. The NUMERIC and NUMERIC[] arms of from_sqlx_postgres_row_to_proxy_row passed the value unboxed, so the crate did not compile with the features proxy and with-bigdecimal together. Same change as upstream master (PR SeaQL#3220), applied on top of tag 2.0.0-rc.41 only. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sea-query 1.0 stores Value::BigDecimal as Option<Box>. The NUMERIC and NUMERIC[] arms of from_sqlx_postgres_row_to_proxy_row passed the value unboxed, so the crate did not compile with the features proxy and with-bigdecimal together. Same change as upstream master (PR #3220), applied on top of tag 2.0.0-rc.41 only.
PR Info
Dependencies
Dependents
Checklist
Release Notes