Repository navigation
cpp: include <algorithm> in operators_promote.cpp (the 2.2.8 release build failed on GCC 14) - #76
Merged
Merged
Conversation
…x release toolchain, no longer gets it through another header; the 2.2.8 release build failed on std::find) Every C++ source and binding file compiles clean under GCC 16 (-fsyntax-only); this was the only one that did not. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2.2.8 release run failed building the Linux wheels (manylinux_2_28, GCC 14):
operators_promote.cpp:224: no matching function for call to find(...). The file usedstd::findwithout<algorithm>; GCC 14 no longer gets it through another header, and CI's Linux build (older GCC) did not show it.One line. Checked: all 220 sources under
src/cpp/srcand all 30 binding files compile withg++-16 -fsyntax-only(this was the only failure); clang-format 18 clean.The Windows wheel job of that run failed on an HTTP 504 downloading virtualenv, unrelated; macOS was cancelled by the others.
🤖 Generated with Claude Code