Repository navigation
Improve testing, fix 2 bugs and prepare a release - #2
Merged
Merged
Conversation
sosthene-nitrokey
force-pushed
the
testing
branch
from
April 12, 2024 10:06
e280c97 to
9386c61
Compare
sosthene-nitrokey
requested review from
a team,
daringer and
robin-nitrokey
and removed request for
a team
November 12, 2026 08:39
sosthene-nitrokey
changed the title
robin-nitrokey
approved these changes
Nov 12, 2026
sosthene-nitrokey
force-pushed
the
testing
branch
from
November 12, 2026 09:57
119c6c9 to
3d2a17a
Compare
Collaborator
Author
|
|
Those still don't test the issue described in a5145bc
sosthene-nitrokey
force-pushed
the
testing
branch
from
November 12, 2026 10:03
3d2a17a to
ccfe654
Compare
robin-nitrokey
approved these changes
Nov 12, 2026
robin-nitrokey
left a comment
robin-nitrokey
left a comment
Member
There was a problem hiding this comment.
LGTM. Maybe also add a test to enforce the UnwindSafe and RefUnwindSafe implementations?
sosthene-nitrokey
force-pushed
the
testing
branch
from
November 12, 2026 14:37
ccfe654 to
e3a78c9
Compare
robin-nitrokey
approved these changes
Nov 12, 2026
This was referenced Nov 12, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional test find no new bugs, but they fail when reverting a5145bc
A variance bug and a missing null check are added.
This is technically breaking but any user encountering the issue would be facing UB. No known users are affected.