Repository navigation
[chore] 연타 게임 웹 버전을 gamss.kr 에 올린다 (dev 반영) - #260
Closed
theminjunchoi wants to merge 1 commit into
Closed
theminjunchoi wants to merge 1 commit into
theminjunchoi wants to merge 1 commit into
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Test Coverage
|
Collaborator
Author
|
prod 에만 반영하기로 해서 닫습니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관 이슈
📌 개요
Android 레포에서 만든 연타 게임(눌러눌러) 웹 버전을
https://gamss.kr/clicker-game.html로 옮깁니다. 지금은 Android PR 브랜치의 GitHub Pages 에 올라가 있어 브랜치가 지워지면 페이지가 내려갑니다(Nexters/GAMSS-Android#83).🔧 주요 변경사항
landing/public/clicker-game.html추가 (Android 레포add-clicker-game브랜치의docs/clicker-game.html그대로, 이미지를 포함한 단일 HTML 약 650KB)🌐 API · DB 영향
💬 리뷰 포인트
prod에서, dev 쪽은dev에서 브랜치를 땄고 내용은 같습니다. 두 브랜치에 같은 파일이 같은 내용으로 들어가므로 다음 dev -> prod 배포 때 충돌하지 않습니다.public/파일은out/루트로 그대로 복사되고, nginxgamss.kr의location /가 실제 파일을 먼저 내려주므로 nginx 설정은 건드리지 않았습니다.frame-ancestors만 걸려 있어 폰트와 인라인 스크립트가 막히지 않습니다.paths는/c/*만 잡으므로 앱을 깐 사람도 브라우저에서 열립니다.