Skip to content

Wall/roof roughness - #2307

Open
shorowit wants to merge 12 commits into
masterfrom
material_roughness
Open

shorowit wants to merge 12 commits into
masterfrom
material_roughness

Conversation

@shorowit

@shorowit shorowit commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Pull Request Description

Adds wall/roof roughness to EnergyPlus materials depending on wall siding type and roofing material type.

DOE-2 roughness:
image

MulTEA roughness for walls:
image

MulTEA roughness for roofs:
image

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.sch) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit self-assigned this Nov 18, 2026
@shorowit shorowit added the enhancement New feature or request label Nov 18, 2026
@shorowit shorowit moved this from Triage to In progress in OpenStudio-HPXML Nov 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new test lacks direct roughness assertions for the ASHRAE 140 benchmark override, rim joists, and the wall-types sample’s asphalt roof.

1 open issue
What changed in this PR

Adds material-specific exterior roughness to the HPXML-to-OpenStudio translation so EnergyPlus walls and roofs reflect their siding and roofing types.

Changes:

  • Map siding and roofing materials to roughness values while preserving ASHRAE 140 benchmark assumptions.
  • Carry roughness through material combination and construction creation, updating helper names and callers.
  • Add roughness assertions and refresh measure metadata, release notes, and result baselines.
File Description
workflow/​tests/​base_results/​results_hers_hot_water.csv Updates two hot-water energy baselines.
HPXMLtoOpenStudio/​tests/​test_enclosure.rb Adds wall and roof roughness assertions.
HPXMLtoOpenStudio/​resources/​materials.rb Defines roughness mappings, inheritance, and benchmark overrides.
HPXMLtoOpenStudio/​resources/​hvac_sizing.rb Uses the renamed foundation-wall material helper.
HPXMLtoOpenStudio/​resources/​geometry.rb Passes header settings to construction helpers and updates material calls.
HPXMLtoOpenStudio/​resources/​constructions.rb Propagates roughness into generated OpenStudio materials.
HPXMLtoOpenStudio/​measure.xml Refreshes version metadata and file checksums.
Changelog.md Documents the roughness feature.

Review effort: Max

@shorowit
shorowit marked this pull request as ready for review November 19, 2026 16:34
shorowit and others added 2 commits November 19, 2026 09:48
…HPXML into material_roughness

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
#	workflow/tests/base_results/results_simulations_bills.csv
#	workflow/tests/base_results/results_simulations_energy.csv
#	workflow/tests/base_results/results_simulations_loads.csv
#	workflow/tests/base_results/results_simulations_misc.csv
when HPXML::SidingTypeAsbestos
thick_in = 0.25 if thick_in.nil?
return new(name: type, thick_in: thick_in, k_in: 4.20, rho: 118.6, cp: 0.24)
mat = new(name: type, thick_in: thick_in, k_in: 4.20, rho: 118.6, cp: 0.24, roughness_num: 3)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's where we define roughnesses for each wall siding.

case roof_type
when HPXML::RoofTypeMetal
mat_roof = new(name: roof_type, thick_in: 0.02, k_in: 346.9, rho: 487.0, cp: 0.11)
mat_roof = new(name: roof_type, thick_in: 0.02, k_in: 346.9, rho: 487.0, cp: 0.11, roughness_num: 5)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's where we define roughnesses for each roof material.

@shorowit
shorowit requested a review from yzhou601 November 19, 2026 18:48
@shorowit shorowit added this to the 1.13.0 milestone Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

2 participants