Repository navigation
Wall/roof roughness - #2307
Open
shorowit wants to merge 12 commits into
Open
Wall/roof roughness#2307shorowit wants to merge 12 commits into
shorowit wants to merge 12 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new test lacks direct roughness assertions for the ASHRAE 140 benchmark override, rim joists, and the wall-types sample’s asphalt roof.
What changed in this PR
Adds material-specific exterior roughness to the HPXML-to-OpenStudio translation so EnergyPlus walls and roofs reflect their siding and roofing types.
Changes:
- Map siding and roofing materials to roughness values while preserving ASHRAE 140 benchmark assumptions.
- Carry roughness through material combination and construction creation, updating helper names and callers.
- Add roughness assertions and refresh measure metadata, release notes, and result baselines.
| File | Description |
|---|---|
| workflow/tests/base_results/results_hers_hot_water.csv | Updates two hot-water energy baselines. |
| HPXMLtoOpenStudio/tests/test_enclosure.rb | Adds wall and roof roughness assertions. |
| HPXMLtoOpenStudio/resources/materials.rb | Defines roughness mappings, inheritance, and benchmark overrides. |
| HPXMLtoOpenStudio/resources/hvac_sizing.rb | Uses the renamed foundation-wall material helper. |
| HPXMLtoOpenStudio/resources/geometry.rb | Passes header settings to construction helpers and updates material calls. |
| HPXMLtoOpenStudio/resources/constructions.rb | Propagates roughness into generated OpenStudio materials. |
| HPXMLtoOpenStudio/measure.xml | Refreshes version metadata and file checksums. |
| Changelog.md | Documents the roughness feature. |
Review effort: Max
shorowit
marked this pull request as ready for review
November 19, 2026 16:34
…HPXML into material_roughness # Conflicts: # HPXMLtoOpenStudio/measure.xml # workflow/tests/base_results/results_simulations_bills.csv # workflow/tests/base_results/results_simulations_energy.csv # workflow/tests/base_results/results_simulations_loads.csv # workflow/tests/base_results/results_simulations_misc.csv
shorowit
commented
Nov 19, 2026
| when HPXML::SidingTypeAsbestos | ||
| thick_in = 0.25 if thick_in.nil? | ||
| return new(name: type, thick_in: thick_in, k_in: 4.20, rho: 118.6, cp: 0.24) | ||
| mat = new(name: type, thick_in: thick_in, k_in: 4.20, rho: 118.6, cp: 0.24, roughness_num: 3) |
Contributor
Author
There was a problem hiding this comment.
Here's where we define roughnesses for each wall siding.
| case roof_type | ||
| when HPXML::RoofTypeMetal | ||
| mat_roof = new(name: roof_type, thick_in: 0.02, k_in: 346.9, rho: 487.0, cp: 0.11) | ||
| mat_roof = new(name: roof_type, thick_in: 0.02, k_in: 346.9, rho: 487.0, cp: 0.11, roughness_num: 5) |
Contributor
Author
There was a problem hiding this comment.
Here's where we define roughnesses for each roof material.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pull Request Description
Adds wall/roof roughness to EnergyPlus materials depending on wall siding type and roofing material type.
DOE-2 roughness:

MulTEA roughness for walls:

MulTEA roughness for roofs:

Checklist
Not all may apply:
EPvalidator.sch) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run