Repository navigation
[stable35] fix(openapi): propagate TypeScript generation failures (stable35 backport) - #9462
Merged
Merged
Conversation
Backport of #9457. Adapt regression tests to the existing PHPUnit unit suite. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #9457 to
stable35Restores correct exit status handling for the OpenAPI/TypeScript generation command and provides an OpenAPI-only alternative:
composer run openapifails when either generator fails.composer run openapi:specregenerates the OpenAPI specification without requiring Node.js.Stable branch adaptation
The
tests/php/openapi/phpunit.xmltest suite introduced onmaindoes not exist onstable35. PlaceOpenApiGenerationTest.phpundertests/php/Unit/instead, so the pre-existingunitsuite discovers it. No change to the stable PHPUnit configuration is needed.Verification
stable35: onlycomposer.jsonandtests/php/Unit/OpenApiGenerationTest.phpchanged.Backport source commit:
83949bb0a69e9bbe12c109aa0618712a17aec7b3.No automatic merge requested.