Repository navigation
Fix settings for exporting mesh #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -88,8 +88,8 @@ void cnoid::robot_assembler::createSceneFromGeometry(SgGroup *sg_main, std::vect | |||
| SgNodePtr shape = sceneLoader.load(geom_file_path); | ||||
| if (!!shape) { | ||||
| DEBUG_STREAM(" mesh loaded!"); | ||||
| shape->setName(name_ + "/geom"); | ||||
| shape->setUri(geom.url, geom_file_path); | ||||
| shape->setName(name_ + "/shape"); | ||||
| //shape->setUri(geom.url, geom_file_path); | ||||
|
||||
| //shape->setUri(geom.url, geom_file_path); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The shape name was changed from "/geom" to "/shape", but the transform name on line 102 still uses "/geom_postrans". This creates a naming inconsistency. Consider either:
Note that line 60 in the addShape helper function uses "geom_postrans" (without prefix), while line 102 uses the prefixed version. Consistency across all geometry types would improve code maintainability.