Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/AssemblerManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1003,6 +1003,8 @@ void AssemblerManager::save_model(ra::RASceneRobot *_sr)
"Embed models", StdSceneWriter::EmbedModels);
extModelFileModeCombo->addItem(
"Link to the original model files", StdSceneWriter::LinkToOriginalModelFiles);
extModelFileModeCombo->addItem(
"Copy model files", StdSceneWriter::CopyModelFiles);
extModelFileModeCombo->addItem(
"Replace with OBJ model files", StdSceneWriter::ReplaceWithObjModelFiles);
extModelFileModeCombo->addItem(
Expand Down
4 changes: 2 additions & 2 deletions src/RobotAssemblerBody.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@ void cnoid::robot_assembler::createSceneFromGeometry(SgGroup *sg_main, std::vect
SgNodePtr shape = sceneLoader.load(geom_file_path);
if (!!shape) {
DEBUG_STREAM(" mesh loaded!");
shape->setName(name_ + "/geom");
shape->setUri(geom.url, geom_file_path);
shape->setName(name_ + "/shape");

Copilot AI Jan 29, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shape name was changed from "/geom" to "/shape", but the transform name on line 102 still uses "/geom_postrans". This creates a naming inconsistency. Consider either:

  1. Keeping the shape name as "/geom" to maintain consistency with the transform name, or
  2. Changing the transform name to "/shape_postrans" to match the new shape naming convention.

Note that line 60 in the addShape helper function uses "geom_postrans" (without prefix), while line 102 uses the prefixed version. Consistency across all geometry types would improve code maintainability.

Copilot uses AI. Check for mistakes.
//shape->setUri(geom.url, geom_file_path);

Copilot AI Jan 29, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The setUri call has been commented out instead of removed. If this change is intended to be permanent, consider removing the commented code entirely. Commented-out code can create confusion about whether it might be needed in the future and makes the codebase harder to maintain.

Suggested change
//shape->setUri(geom.url, geom_file_path);

Copilot uses AI. Check for mistakes.
if(!_color.isZero()) {
addMaterial(shape, _color);
} else if (geom.color[0] >= 0.0) { // checking color is changed
Expand Down