Repository navigation
add datasetType OutputManagementPlan - #12880
cesarpferreira wants to merge 8 commits into
Conversation
| case DatasetType.DATASET_TYPE_DATASET -> "Dataset"; | ||
| case DatasetType.DATASET_TYPE_SOFTWARE -> "Software"; | ||
| case DatasetType.DATASET_TYPE_WORKFLOW -> "Workflow"; | ||
| case DatasetType.DATASET_TYPE_OUTPUTMANAGEMENTPLAN -> "OutputManagementPlan"; |
There was a problem hiding this comment.
I double-checked that OutputManagementPlan is part of the controlled vocabulary at https://datacite-metadata-schema.readthedocs.io/en/4.5/appendices/appendix-1/resourceTypeGeneral/
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
Overall, looks great! Thanks for the pull request, @cesarpferreira! 🎉
I'm leaving you a few comments.
| public static final String DATASET_TYPE_SOFTWARE = "software"; | ||
| public static final String DATASET_TYPE_WORKFLOW = "workflow"; | ||
| public static final String DATASET_TYPE_REVIEW = "review"; | ||
| public static final String DATASET_TYPE_OUTPUTMANAGEMENTPLAN = "outputmanagementplan"; |
There was a problem hiding this comment.
This will be all lower case in the search facet. Here's some related discussion: IQSS/dataverse-frontend#809 (comment)
There was a problem hiding this comment.
I changed the value to camel case, it is a bit easier to read than full lower case.
There was a problem hiding this comment.
No objection I updated the docs to match.
| * - review | ||
| - <resourceType resourceTypeGeneral="Other">Review</resourceType> | ||
| * - outputManagementPlan | ||
| - <resourceType resourceTypeGeneral="OutputManagementPlan">Data Management Plan</resourceType> |
There was a problem hiding this comment.
Is there any particular thinking behind having "Data Management Plan" in the XML like this?
<resourceType resourceTypeGeneral="OutputManagementPlan">Data Management Plan</resourceType>
Did you consider other terms or is this just the obvious one?
This PR adds compatibility with resourceType
OutputManagementPlanin DataCite by using datasetTypeoutputmanagementplan.Preview docs at https://dataverse-guide--12880.org.readthedocs.build/en/12880/user/dataset-management.html#output-management-plan-datasets