Repository navigation
build: bump array-api-strict lower bound to 2.5 - #2993
Merged
Merged
Conversation
test_program_slicing deep-copies an array_api_strict-backed field; array-api-strict 2.4 and 2.4.1 raise TypeError from Array.__new__ on copy.deepcopy, which broke the lowest-direct daily CI.
Contributor
Author
|
🤖 Written by an agent on behalf of @havogt |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
⚙️ Agent run details
|
Contributor
Author
I guess we need to make sure the agent sees the full diff... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daily CI job with
lowest-directresolution fails intest_next(internal, cpu, nomesh)ontest_program_slicing[array_api_strict_execution](https://github.com/GridTools/gt4py/actions/runs/43569385271). The test callscopy.deepcopyon a field backed by array_api_strict, and array-api-strict 2.4 and 2.4.1 raiseTypeErrorfromArray.__new__. Arrays became picklable in array-api-strict 2.5 (data-apis/array-api-strict#192), so this raises the test-group floor to>=2.5. The lockfile changes only in the specifier metadata.