Skip to content

build: bump array-api-strict lower bound to 2.5 - #2993

Merged
havogt merged 1 commit into
GridTools:mainfrom
havogt:lowest-deps-bounds
Nov 16, 2026
Merged

havogt merged 1 commit into
GridTools:mainfrom
havogt:lowest-deps-bounds

Conversation

@havogt

@havogt havogt commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

The daily CI job with lowest-direct resolution fails in test_next(internal, cpu, nomesh) on test_program_slicing[array_api_strict_execution] (https://github.com/GridTools/gt4py/actions/runs/43569385271). The test calls copy.deepcopy on a field backed by array_api_strict, and array-api-strict 2.4 and 2.4.1 raise TypeError from Array.__new__. Arrays became picklable in array-api-strict 2.5 (data-apis/array-api-strict#192), so this raises the test-group floor to >=2.5. The lockfile changes only in the specifier metadata.

test_program_slicing deep-copies an array_api_strict-backed field; array-api-strict 2.4 and 2.4.1 raise TypeError from Array.__new__ on copy.deepcopy, which broke the lowest-direct daily CI.
@havogt
havogt requested a review from egparedes November 14, 2026 15:16
@havogt

havogt commented Nov 14, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Written by an agent on behalf of @havogt

@github-actions

Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
✅ Merge recommendation: No concerns found
🔎 Failure modes

What: If `uv.lock` was not regenerated consistently with the new `>=2.5` floor, frozen installs (e.g. CI `uv sync --frozen`) would still resolve array-api-strict 2.4.x and the `TypeError` from `Array.__new__` on `copy.deepcopy` in `test_program_slicing[array_api_strict_execution]` would persist. The `uv.lock` diff is omitted from the visible changes, so this cannot be verified here.
Where: pyproject.toml:test dependency group (uv.lock not visible in this review)
Trigger: Daily `lowest-direct` CI job, or any frozen install from a stale lockfile.
Detected by: The daily lowest-direct CI job, or `uv lock --check` failing.
Covered in this PR: No

🏅 Score: 94
🧪 No relevant tests
🔒 No security concerns identified
🔀 No multiple PR themes
⚡ No major issues detected

⚙️ Agent run details
  • Model: openai/zai-org/GLM-5.3-Flash
  • Tokens: 6,608 in / 3,498 out / 10,106 total
  • Time cost: 67.5s
  • AI calls: 1

@havogt

havogt commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

The uv.lock diff is omitted from the visible changes, so this cannot be verified here.

I guess we need to make sure the agent sees the full diff...

@egparedes egparedes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@havogt
havogt merged commit 57f97b9 into GridTools:main Nov 16, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants