Repository navigation
Fixes #1827: Escape custom quote char when CharacterEscapes are configured - #1826
Merged
cowtowncoder merged 10 commits intoNov 15, 2026
Merged
Conversation
Member
|
Let's split problem description into actual Issue, leaving PR for fix and implementation aspects (hence |
Contributor
Author
|
Makes sense, filed #1827 with the problem description and trimmed the PR description down to the fix. |
| * Helper method for making sure that ASCII escape codes from custom | ||
| * {@link CharacterEscapes} still escape the quote character in use, | ||
| * if the custom definitions do not already do so. | ||
| */ |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…SInCE tags Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rload Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1827
UTF8JsonGeneratorandWriterBasedJsonGenerator.setCharacterEscapes()now pass the custom ASCII escape table through a newJsonGeneratorBase._escapesWithQuoteChar()helper. If the table doesn't already escape the configured quote char, it's copied (the caller's array isn't mutated) and the quote char gets an escape: backslash-escaped for'/",ESCAPE_STANDARDotherwise. Tables that already escape it are returned unchanged.Test:
CustomQuoteCharTest.aposQuotingWithCustomEscapescovers both theWriterandOutputStreamgenerators.