Skip to content

fix: respect on-exit during reload - #1443

Closed
rituzzzpilot wants to merge 2 commits into
Exa-Networks:mainfrom
rituzzzpilot:withdraw-on-reload
Closed

rituzzzpilot wants to merge 2 commits into
Exa-Networks:mainfrom
rituzzzpilot:withdraw-on-reload

Conversation

@rituzzzpilot

Copy link
Copy Markdown

When a helper is removed from the configuration, we expect its routes
to be withdrawn if on-exit is set to withdraw. Currently, they remain
advertised after reload.

This change applies the existing on-exit policy when a reload removes
or replaces a helper. It also adds regression tests and updates the
documentation

rituzzzpilot and others added 2 commits October 27, 2026 13:43
Apply on-exit when a reload removes an API process or a full reload restarts it. Use the old process's policy and API version to decide whether to withdraw or keep its routes. Process withdrawals before announcements from the new process.

Add tests for process removal and replacement, exit policies, and route ownership. Document on-exit behavior during reload.
@thomas-mangin

Copy link
Copy Markdown
Member

Hello @rituzzzpilot,

Thank you for the fix and for the tests, they were spot on: without the two _queue_exit calls, ten of them fail.

I applied your commit to main as 99ed4ee, rebased but otherwise unchanged, so you remain its author. I then added 8252b2b on top, which adds a CHANGELOG entry, rewords the manual page paragraph a little, and adds a comment in Processes.start explaining that _queue_exit must run before the configuration is replaced. As the change is now on main, I am closing this PR.

GitHub shows the commit under your name without linking it to this account, as its author email (m.larina@vk.team) is not one of the addresses on rituzzzpilot. Should you want it credited to your profile, add and verify that address under Settings → Emails, and GitHub will link the commit (and your other commits using that address) on its own.

@rituzzzpilot
rituzzzpilot deleted the withdraw-on-reload branch November 5, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants