Repository navigation
Conversation
ST7735_Defines.h hard-codes ST7735_GREENTAB160x80. Because of the order of the tab #if chain, that default wins over -DST7735_REDTAB, -DST7735_BLACKTAB and -DST7735_REDTAB160x80 given as build flags, which gives inverted colours and a 26-pixel shift on 128x160 panels. Only define the 160x80 default when no tab flag is set. Boards that set no flag are unchanged. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…16R8 ST7735 waveshare-c5-kit-ili9341: Waveshare ESP32-C5-WIFI6-KIT with the 2.8" ILI9341 + XPT2046 SPI module. The kit ties GPIO6 to its battery-sense divider (100 nF to GND), so esp32-c5-tft, which clocks the display on GPIO6, shows a white screen on it. This env uses the display pins from Waveshare's ILI9341 demo and keeps GPIO6 for the backlight. esp32-s3-n16r8-st7735: ESP32-S3 N16R8 DevKitC-1 style board with a 1.8" ST7735 128x160 SPI screen and three buttons. Both are added to the build matrix and the README board table, and each board folder has a connections.md with wiring and pins to avoid. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Two new board targets for common DIY builds, plus a small TFT_eSPI fix that one of them needs.
waveshare-c5-kit-ili9341: Waveshare ESP32-C5-WIFI6-KIT (WROOM-1 / -1U) with the 2.8" ILI9341 + XPT2046 SPI module (MSP2807).The existing
esp32-c5-tftenv shows a white screen on this kit: the kit ties GPIO6 (R39, 0 ohm) to its battery-sense divider, which has a 100 nF capacitor to GND, andesp32-c5-tftuses GPIO6 as the SPI clock. The new env uses the display pins from Waveshare's own ILI9341 demo for this kit (SCK 1, MOSI 2, CS 5, DC 3, RST 4) and keeps GPIO6 for the backlight. It is otherwise a copy ofesp32-c5-tft(same touch HAL and calibration). Module defaults are moved off the display pins: I2C / GPS / CH9329 on 24/25 and the IR LED on 0, because 3, 4 and 5 are display pins here.esp32-s3-n16r8-st7735: ESP32-S3 N16R8 DevKitC-1 style board with a 1.8" ST7735 128x160 SPI screen and three buttons (HAL 3-button layout: previous + next = back). The screen is on its own HSPI bus; SD / CC1101 / NRF24 share the usual 11/12/13 bus. I2C uses GPIO47 instead of GPIO46 (strapping pin).TFT_eSPI
ST7735_Defines.h: the bundled header hard-codesST7735_GREENTAB160x80. Because of the order of the tab#ifchain, that default wins over-DST7735_REDTAB,-DST7735_BLACKTABand-DST7735_REDTAB160x80given as build flags, which gives inverted colours and a 26-pixel shift on 128x160 panels. The change only defines the 160x80 default when no tab flag is set, so boards that set no flag (and Marauder-Mini, which setsGREENTAB3, already ahead of the default in the chain) are unchanged.Each board folder has a
connections.mdwith wiring, module defaults and pins to avoid.Types of Changes
New feature (two board targets). Small bug fix in the bundled TFT_eSPI (
ST7735_Defines.h).Verification
The branch is on
dev97de7f8.pio run -e waveshare-c5-kit-ili9341andpio run -e esp32-s3-n16r8-st7735build cleanly there, with no warnings from the new board files.pio run -e Marauder-Mini(the existing ST7735 board, as a check on the shared change) also builds cleanly with the change (checked ondev22e72a1).ST7735_Defines.hchange, checked by preprocessing the header with each tab flag (value ofTAB_COLOUR):ST7735_GREENTAB/GREENTAB2/GREENTAB3/GREENTAB128ST7735_REDTAB160x80ST7735_REDTABST7735_BLACKTABHardware (tested on
dev22e72a1; thedevchanges since then are in the I2C / RFID code):ST7735_GREENTAB2, previous / next / select and previous + next = back, brightness control. PASS.Both boards ran the same pin maps on a pre-refactor build of
mainbefore this port.Testing
Manual testing on the hardware above. Not tested yet: SD card, CC1101, NRF24, PN532 (default pins set, nothing wired).
Linked Issues
None. Board layout follows
boards/README.mdandboards/_New-Device-Model;waveshare-c5-kit-ili9341is based onESP32-C5-tft.User-Facing Change
Further Comments
The ST7735 build defaults to
ST7735_GREENTAB2, which suits the common red 1.8" module;connections.mdsays which tab flags to try if a module shows a noise strip or wrong colours.🤖 Generated with Claude Code