Repository navigation
fix: declare click as a dependency - #666
Open
Amine E. (aelmanaa) wants to merge 1 commit into
Open
Amine E. (aelmanaa) wants to merge 1 commit into
Amine E. (aelmanaa) wants to merge 1 commit into
Conversation
`typer_validators` imports click directly, but it was only installed as a dependency of typer. typer 0.26.0 dropped that dependency, so a plain `pip install safe-cli` fails with `ModuleNotFoundError: No module named 'click'` unless the `trezor` extra (which depends on click) is installed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
Uxío (@Uxio0) gentle ping on this one when you have a moment. It's a one-line dependency fix for #665 (a plain The CLA check is still red only because the bot can't record signatures (details in safe-global/safe-core-sdk#1439). I signed here on Oct 15. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #665
Declares
click>=8, whichsafe_cli/typer_validators.pyimports directly and which typer no longer depends on since 0.26.0.uv.lockonly gains the new requirement; no versions change.I checked that safe-cli's
click.ParamTypeparsers still work with typer 0.27.2 (which uses its own vendored click internally): withclickinstalled, an invalid address still getsInvalid value for 'safe_address': Invalid ethereum address, and a valid one is parsed and reaches the Safe lookup.Tests:
test_click_is_a_required_dependencychecks that click is a non-extra requirement of the installed package; it fails onmainand passes here.main; 84 passed, 1 skipped here.pre-commit run --all-filespasses.safe-cliwithout theModuleNotFoundError.This PR was prepared with Claude Code; the checks above were run locally.