From 9682bced7f8116f77963de859bab711edf030f35 Mon Sep 17 00:00:00 2001 From: Rob Reed Date: Thu, 27 Aug 2026 19:38:51 -0700 Subject: [PATCH 1/8] Publish releases to GitHub Packages under the @plexinc scope. Replace the git tag and xelp/dist shadow release with a workflow that publishes to GitHub Packages as @plexinc/, matching how the other Plex client repos consume private packages. Authentication is the workflow GITHUB_TOKEN, so the repository stores no publishing secret, and the package name is rewritten in CI rather than on xelp/main, leaving upstream merges unaffected. The lint and test suites previously ran as a side effect of npm version, which triggers preversion. This package has no prepublishOnly script, so without that side effect nothing would gate the publish. They now run as their own steps. Consumers keep the upstream package name by installing through an npm alias, so imports, bin names and plugin references do not change. --- .github/workflows/xelp_npm_release.yml | 182 +++++++++++++++++++++++++ 1 file changed, 182 insertions(+) create mode 100644 .github/workflows/xelp_npm_release.yml diff --git a/.github/workflows/xelp_npm_release.yml b/.github/workflows/xelp_npm_release.yml new file mode 100644 index 0000000..eff8f13 --- /dev/null +++ b/.github/workflows/xelp_npm_release.yml @@ -0,0 +1,182 @@ +name: Xelp npm Release + +# Builds the current xelp/main, publishes it to GitHub Packages as +# @plexinc/, then tags the commit and creates a GitHub release. +# +# Authentication is the workflow's own GITHUB_TOKEN, so there is no secret to +# provision or rotate. Consumers authenticate the way every other Plex client +# repo does, with a personal access token carrying read:packages. +# +# This replaces xelp_shadow_release.yml, which committed dist/ to the xelp/dist +# branch and served the package to consumers through a git tag. Run one or the +# other, never both: they compute the same version string and so want the same +# tag, and the shadow release force pushes it. +# +# Keep the shadow release around until roku-client, the only consumer of these +# forks, is installing from the @plexinc package. Then delete it. +# + +on: + workflow_dispatch: + inputs: + dryRun: + description: Build and pack, but do not publish, tag, or release. + type: boolean + default: false + +# packages: write is the publish permission. contents: write is only for the +# tag and the release. +# +permissions: + contents: write + packages: write + +jobs: + release: + runs-on: blacksmith-2vcpu-ubuntu-2404 + env: + # Needed by every npm step, to read @plexinc dependencies as well as to + # publish. Setting it per step is easy to get wrong: a fork that depends + # on another @plexinc package cannot even run npm ci without it. + # + NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + steps: + - name: Check out xelp/main + uses: actions/checkout@v5 + with: + ref: xelp/main + fetch-depth: 0 + + - name: Set up Node.js + uses: actions/setup-node@v5 + with: + node-version: 20 + registry-url: https://npm.pkg.github.com + scope: '@plexinc' + + - name: Configure git + run: | + git config user.name "github-actions[bot]" + git config user.email "github-actions[bot]@users.noreply.github.com" + + - name: Work out the package name and version + id: release + run: | + set -euo pipefail + + UPSTREAM_NAME=$(node -p "require('./package.json').name") + + # Re-scope to @plexinc, dropping any existing scope, so + # @rokucommunity/bslint becomes @plexinc/bslint. GitHub Packages + # requires the scope to match the owner of this repository. + # + SCOPED_NAME="@plexinc/${UPSTREAM_NAME##*/}" + + # Version scheme, unchanged from the shadow release: the upstream major + # and minor, then the build date with the upstream patch appended, so + # 0.70.3 built on 2026-08-28 becomes 0.70.202608283. + # + CURRENT_VERSION=$(node -p "require('./package.json').version") + BASE_VERSION=${CURRENT_VERSION%%[-+]*} + + IFS='.' read -r -a PARTS <<< "$BASE_VERSION" + if [ ${#PARTS[@]} -ne 3 ]; then + echo "::error::Version $CURRENT_VERSION is not MAJOR.MINOR.PATCH" + exit 1 + fi + + VERSION="${PARTS[0]}.${PARTS[1]}.$(date -u +'%Y%m%d')${PARTS[2]}" + + { + echo "upstream_name=$UPSTREAM_NAME" + echo "scoped_name=$SCOPED_NAME" + echo "version=$VERSION" + echo "metadata_version=$VERSION+xelp-$(git rev-parse --short HEAD)" + } >> "$GITHUB_OUTPUT" + + # Published versions are immutable and tags are no longer force-pushed, so + # a same day re-run would collide twice over. Fail before doing the work. + # + - name: Fail if this version is already published + env: + SCOPED_NAME: ${{ steps.release.outputs.scoped_name }} + VERSION: ${{ steps.release.outputs.version }} + run: | + if npm view "$SCOPED_NAME@$VERSION" version >/dev/null 2>&1; then + echo "::error::$SCOPED_NAME@$VERSION is already published. Land another commit, or wait for tomorrow's date stamp." + exit 1 + fi + + # The upstream lockfile is what keeps the transitive dependencies on + # working versions, so install from it rather than re-resolving. A clean + # re-resolve floats vscode-languageserver-protocol onto an exports only + # release that the TypeScript build cannot import. + # + - name: Install dependencies + run: npm ci + + - name: Build + run: npm run build + + # The shadow release ran the lint and test suites as a side effect of + # npm version, which triggers the preversion script. Setting the version + # through npm pkg set does not run lifecycle scripts, so the gate runs + # here where a failure names the step that failed. + # + - name: Lint + run: npm run lint + + - name: Test + run: npm test + + # The rename happens here and is never committed to xelp/main, so a merge + # from upstream never has to resolve a changed package name. The repository + # URL is what links the package to this repo, and GitHub Packages rejects + # the publish if it points anywhere else. + # + - name: Rewrite the package metadata for the @plexinc scope + env: + SCOPED_NAME: ${{ steps.release.outputs.scoped_name }} + VERSION: ${{ steps.release.outputs.version }} + run: | + npm pkg set name="$SCOPED_NAME" + npm pkg set version="$VERSION" + npm pkg set repository.url="git+https://github.com/${{ github.repository }}.git" + + - name: Publish to GitHub Packages + if: ${{ !inputs.dryRun }} + run: npm publish + + - name: Pack without publishing + if: ${{ inputs.dryRun }} + run: npm pack --dry-run + + - name: Tag the release + if: ${{ !inputs.dryRun }} + env: + VERSION: ${{ steps.release.outputs.version }} + METADATA_VERSION: ${{ steps.release.outputs.metadata_version }} + run: | + git tag -a "$VERSION" -m "Release $METADATA_VERSION" + git push origin "$VERSION" + + - name: Create the GitHub release + if: ${{ !inputs.dryRun }} + env: + GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + UPSTREAM_NAME: ${{ steps.release.outputs.upstream_name }} + SCOPED_NAME: ${{ steps.release.outputs.scoped_name }} + VERSION: ${{ steps.release.outputs.version }} + METADATA_VERSION: ${{ steps.release.outputs.metadata_version }} + run: | + gh release create "$VERSION" \ + --repo "$GITHUB_REPOSITORY" \ + --title "$SCOPED_NAME $VERSION" \ + --notes "Built from \`$METADATA_VERSION\`. + + Consume it with an alias, so the package keeps its upstream name inside \`node_modules\`: + + \`\`\`json + \"$UPSTREAM_NAME\": \"npm:$SCOPED_NAME@$VERSION\" + \`\`\`" \ + --prerelease From 2c86e01455b2ce18d8567abcc2c85e259143d5bd Mon Sep 17 00:00:00 2001 From: Rob Reed Date: Thu, 27 Aug 2026 19:38:51 -0700 Subject: [PATCH 2/8] Disable the shadow release in favour of the npm release. Both workflows compute the same MAJOR.MINOR. version and so want the same tag, and the shadow release force pushes it, so running the two against one commit means one clobbers the other. Park the shadow release rather than delete it, so restoring it is a rename. roku-client is the only consumer of this fork, and it keeps installing from the existing git tag until it moves to the @plexinc package, so nothing depends on this workflow staying runnable in the meantime. --- .../{xelp_shadow_release.yml => xelp_shadow_release.yml.disabled} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/workflows/{xelp_shadow_release.yml => xelp_shadow_release.yml.disabled} (100%) diff --git a/.github/workflows/xelp_shadow_release.yml b/.github/workflows/xelp_shadow_release.yml.disabled similarity index 100% rename from .github/workflows/xelp_shadow_release.yml rename to .github/workflows/xelp_shadow_release.yml.disabled From d4b17fc43bdc01487a1b81da212798b8b67c0079 Mon Sep 17 00:00:00 2001 From: Rob Reed Date: Thu, 27 Aug 2026 19:38:51 -0700 Subject: [PATCH 3/8] Develop against the published @plexinc/brighterscript package. Point the development dependency at the GitHub Packages release rather than a git tag, so a checkout no longer clones the brighterscript repo to build. The .npmrc tells npm where the @plexinc scope lives, matching the other Plex client repos. The peer dependency range is left alone. It is satisfied by the aliased package, which npm installs under the brighterscript name, so consumers resolve it the same way they do today. The swap was made with a targeted npm install rather than by regenerating the lockfile, which changed one entry out of 519. A clean re-resolve floats vscode-languageserver-protocol onto a release that ships exports with no main or types entry, and the TypeScript build then fails with about thirty type errors. That failure predates this change and is not caused by it. --- .npmrc | 3 +++ package-lock.json | 8 +++++--- package.json | 2 +- 3 files changed, 9 insertions(+), 4 deletions(-) create mode 100644 .npmrc diff --git a/.npmrc b/.npmrc new file mode 100644 index 0000000..3ccf31e --- /dev/null +++ b/.npmrc @@ -0,0 +1,3 @@ +# Use GitHub for @plexinc packages. +@plexinc:registry=https://npm.pkg.github.com/ +//npm.pkg.github.com/:always-auth=true diff --git a/package-lock.json b/package-lock.json index 45cf92e..ef6e7f7 100644 --- a/package-lock.json +++ b/package-lock.json @@ -25,7 +25,7 @@ "@types/node": "^14.6.0", "@typescript-eslint/eslint-plugin": "^3.10.1", "@typescript-eslint/parser": "^3.10.1", - "brighterscript": "https://github.com/plexinc/brighterscript.git#0.70.202603123", + "brighterscript": "npm:@plexinc/brighterscript@^0.70.0", "chai": "^4.3.6", "coveralls-next": "^4.2.0", "eslint": "^7.7.0", @@ -1228,8 +1228,10 @@ } }, "node_modules/brighterscript": { - "version": "0.70.202603123", - "resolved": "git+ssh://git@github.com/plexinc/brighterscript.git#b1c0191837cb61b938015f9ba086348820513f97", + "name": "@plexinc/brighterscript", + "version": "0.70.202608283", + "resolved": "https://npm.pkg.github.com/download/@plexinc/brighterscript/0.70.202608283/f0a4be489585bc03e84d8e3a012494f4872fc347", + "integrity": "sha512-ixJVQQmh1UO1th6/0p8Sh9yg1hXctWyK328o5Oi0gi1UhtuWIUftrwtLXRks3ZSpSAgf+Wsb+XoRY65N79cDeQ==", "dev": true, "license": "MIT", "dependencies": { diff --git a/package.json b/package.json index 13f270d..02ba6e9 100644 --- a/package.json +++ b/package.json @@ -48,7 +48,7 @@ "@types/node": "^14.6.0", "@typescript-eslint/eslint-plugin": "^3.10.1", "@typescript-eslint/parser": "^3.10.1", - "brighterscript": "https://github.com/plexinc/brighterscript.git#0.70.202603123", + "brighterscript": "npm:@plexinc/brighterscript@^0.70.0", "chai": "^4.3.6", "coveralls-next": "^4.2.0", "eslint": "^7.7.0", From 4121a9e23c065e9ebbcf7e4de900de58c95ded91 Mon Sep 17 00:00:00 2001 From: Rob Reed Date: Thu, 27 Aug 2026 19:51:21 -0700 Subject: [PATCH 4/8] Give CI access to the @plexinc registry. The build workflow runs npm ci, and this package now depends on @plexinc/brighterscript from GitHub Packages, so the install needs a token. Without it the job fails with a 401 before it gets as far as compiling. setup-node points the @plexinc scope at the registry and the token is given only to the install step, which is the only step here that reaches the network. --- .github/workflows/build.yml | 7 ++++++- .github/workflows/create-package.yml | 7 ++++++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 3e3f21f..c2cf694 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -20,7 +20,12 @@ jobs: with: node-version: "14.18.1" architecture: 'x64' # fix for macos-latest - - run: npm ci + registry-url: 'https://npm.pkg.github.com' + scope: '@plexinc' + - name: npm ci + env: + NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + run: npm ci - run: npm run build - run: npm run lint - run: npm run test diff --git a/.github/workflows/create-package.yml b/.github/workflows/create-package.yml index 1e5e876..c484053 100644 --- a/.github/workflows/create-package.yml +++ b/.github/workflows/create-package.yml @@ -13,6 +13,8 @@ jobs: - uses: actions/setup-node@master with: node-version: "14.19.0" + registry-url: 'https://npm.pkg.github.com' + scope: '@plexinc' # Get a bot token so the bot's name shows up on all our actions - name: Get Token From roku-ci-token Application uses: tibdex/github-app-token@v1 @@ -33,7 +35,10 @@ jobs: echo "BUILD_VERSION=$BUILD_VERSION" >> $GITHUB_ENV echo "ARTIFACT_URL=$ARTIFACT_URL" >> $GITHUB_ENV - - run: npm ci + - name: npm ci + env: + NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + run: npm ci - run: npm version "$BUILD_VERSION" --no-git-tag-version - run: npm pack From e9771e9a241bb09f9004dcb2bb20609b42cf439c Mon Sep 17 00:00:00 2001 From: Rob Reed Date: Thu, 27 Aug 2026 19:51:21 -0700 Subject: [PATCH 5/8] Scope the registry token to the steps that use npm. The token was on the job, which put it in the environment of every step, including any added later. It is only needed by the three steps that talk to the registry: the published version check, the install, and the publish. Building, linting, testing and packing do not reach the network. A step that runs npm against the registry has to opt in from now on, which is easy to forget, so the reason is written next to the first one. --- .github/workflows/xelp_npm_release.yml | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/.github/workflows/xelp_npm_release.yml b/.github/workflows/xelp_npm_release.yml index eff8f13..508e2c3 100644 --- a/.github/workflows/xelp_npm_release.yml +++ b/.github/workflows/xelp_npm_release.yml @@ -34,12 +34,6 @@ permissions: jobs: release: runs-on: blacksmith-2vcpu-ubuntu-2404 - env: - # Needed by every npm step, to read @plexinc dependencies as well as to - # publish. Setting it per step is easy to get wrong: a fork that depends - # on another @plexinc package cannot even run npm ci without it. - # - NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} steps: - name: Check out xelp/main uses: actions/checkout@v5 @@ -99,6 +93,12 @@ jobs: # - name: Fail if this version is already published env: + # Only the three steps that talk to the registry get the token: this + # one, the install, and the publish. Building, linting, testing and + # packing do not reach the network, so they do not need it. Add it to + # any new step that runs npm against the registry. + # + NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} SCOPED_NAME: ${{ steps.release.outputs.scoped_name }} VERSION: ${{ steps.release.outputs.version }} run: | @@ -113,6 +113,8 @@ jobs: # release that the TypeScript build cannot import. # - name: Install dependencies + env: + NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: npm ci - name: Build @@ -145,6 +147,8 @@ jobs: - name: Publish to GitHub Packages if: ${{ !inputs.dryRun }} + env: + NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: npm publish - name: Pack without publishing From 5905d079d3e5cfdb47820202dff029a40adbd916 Mon Sep 17 00:00:00 2001 From: Rob Reed Date: Thu, 27 Aug 2026 20:35:25 -0700 Subject: [PATCH 6/8] Read @plexinc dependencies with the organization token. A repository's own GITHUB_TOKEN cannot read a package owned by another repository, so npm ci fails with a 403 on @plexinc/brighterscript. GH_TOKEN is the token the other Plex client repos already use for this. Only the install steps change. The published version check and the publish act on this repository's own package, where GITHUB_TOKEN is correct and already works. The fallback keeps a fork that has no @plexinc dependencies working on the repo token alone. --- .github/workflows/build.yml | 2 +- .github/workflows/create-package.yml | 2 +- .github/workflows/xelp_npm_release.yml | 7 ++++++- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index c2cf694..6f77837 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -24,7 +24,7 @@ jobs: scope: '@plexinc' - name: npm ci env: - NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + NODE_AUTH_TOKEN: ${{ secrets.GH_TOKEN || secrets.GITHUB_TOKEN }} run: npm ci - run: npm run build - run: npm run lint diff --git a/.github/workflows/create-package.yml b/.github/workflows/create-package.yml index c484053..a5e739f 100644 --- a/.github/workflows/create-package.yml +++ b/.github/workflows/create-package.yml @@ -37,7 +37,7 @@ jobs: - name: npm ci env: - NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + NODE_AUTH_TOKEN: ${{ secrets.GH_TOKEN || secrets.GITHUB_TOKEN }} run: npm ci - run: npm version "$BUILD_VERSION" --no-git-tag-version - run: npm pack diff --git a/.github/workflows/xelp_npm_release.yml b/.github/workflows/xelp_npm_release.yml index 508e2c3..6e91c6f 100644 --- a/.github/workflows/xelp_npm_release.yml +++ b/.github/workflows/xelp_npm_release.yml @@ -114,7 +114,12 @@ jobs: # - name: Install dependencies env: - NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + # Dependencies can live in another repo's package, and a repository's + # own GITHUB_TOKEN cannot read those, so prefer the organization token. + # The fallback keeps this working in a fork that has no @plexinc + # dependencies, where the repo token is enough. + # + NODE_AUTH_TOKEN: ${{ secrets.GH_TOKEN || secrets.GITHUB_TOKEN }} run: npm ci - name: Build From 035fbe30ec6482671594b5fcb4eb50c2cd98376c Mon Sep 17 00:00:00 2001 From: Rob Reed Date: Thu, 27 Aug 2026 22:00:07 -0700 Subject: [PATCH 7/8] Fail early on a tag collision, and drop the unused token fallback. The publish runs before the tag is pushed, and a published version cannot be replaced, so a tag that already exists would be discovered only after the package had shipped, leaving a release that no re-run can tag. The shadow release used this same version scheme, so its tags are real candidates. Check for the tag in the same preflight that checks the published version. Reading a dependency from another repository's package is granted through that package's Manage Actions access, which makes GITHUB_TOKEN sufficient. No organization secret reaches these forks, so the GH_TOKEN fallback could never have resolved to anything, and its presence only suggested otherwise. Also state explicitly that CI needs packages: read, rather than depending on a repository default that an organization can tighten, and stop describing the dry run as packing when it only reports what would be packed. --- .github/workflows/build.yml | 5 +++++ .github/workflows/xelp_npm_release.yml | 30 ++++++++++++++++++-------- 2 files changed, 26 insertions(+), 9 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 6f77837..db48d9c 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -8,6 +8,11 @@ on: jobs: ci: runs-on: ${{ matrix.os }} + # npm ci reads @plexinc packages, so do not rely on the repository + # default, which an organization can tighten without warning. + permissions: + contents: read + packages: read env: #hardcode the coveralls token...it's not overly important to protect, and github actions won't allow forks to work with coveralls otherwise COVERALLS_REPO_TOKEN: "xTzWrR5HfbescAFnSnVXmWsVVMYglUMZi" diff --git a/.github/workflows/xelp_npm_release.yml b/.github/workflows/xelp_npm_release.yml index 6e91c6f..03f8cf9 100644 --- a/.github/workflows/xelp_npm_release.yml +++ b/.github/workflows/xelp_npm_release.yml @@ -4,8 +4,10 @@ name: Xelp npm Release # @plexinc/, then tags the commit and creates a GitHub release. # # Authentication is the workflow's own GITHUB_TOKEN, so there is no secret to -# provision or rotate. Consumers authenticate the way every other Plex client -# repo does, with a personal access token carrying read:packages. +# provision or rotate. Reading a dependency that lives in another repository's +# package needs that repository granted under the package's Manage Actions +# access, not a different token. Consumers authenticate the way every other Plex +# client repo does, with a personal access token carrying read:packages. # # This replaces xelp_shadow_release.yml, which committed dist/ to the xelp/dist # branch and served the package to consumers through a git tag. Run one or the @@ -20,7 +22,7 @@ on: workflow_dispatch: inputs: dryRun: - description: Build and pack, but do not publish, tag, or release. + description: Build and report what would be packed, without publishing, tagging or releasing. type: boolean default: false @@ -107,6 +109,16 @@ jobs: exit 1 fi + # The publish happens before the tag, and a published version cannot be + # replaced, so a tag collision found at the tagging step would leave a + # published package that no re-run can tag. The shadow release used this + # same version scheme, so its tags are real candidates for a collision. + # + if git ls-remote --exit-code --tags origin "refs/tags/$VERSION" >/dev/null 2>&1; then + echo "::error::Tag $VERSION already exists. Land another commit, or wait for tomorrow's date stamp." + exit 1 + fi + # The upstream lockfile is what keeps the transitive dependencies on # working versions, so install from it rather than re-resolving. A clean # re-resolve floats vscode-languageserver-protocol onto an exports only @@ -114,12 +126,12 @@ jobs: # - name: Install dependencies env: - # Dependencies can live in another repo's package, and a repository's - # own GITHUB_TOKEN cannot read those, so prefer the organization token. - # The fallback keeps this working in a fork that has no @plexinc - # dependencies, where the repo token is enough. + # Reading a dependency published from another repository requires that + # repository to be listed under the package's Manage Actions access. + # The grant is per package and is not inherited, so a newly published + # @plexinc package needs its consumers added before this will resolve. # - NODE_AUTH_TOKEN: ${{ secrets.GH_TOKEN || secrets.GITHUB_TOKEN }} + NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: npm ci - name: Build @@ -156,7 +168,7 @@ jobs: NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: npm publish - - name: Pack without publishing + - name: Report what would be packed if: ${{ inputs.dryRun }} run: npm pack --dry-run From dc919eb49819164a36e9afe478eed03e46074906 Mon Sep 17 00:00:00 2001 From: Rob Reed Date: Thu, 27 Aug 2026 22:02:11 -0700 Subject: [PATCH 8/8] Run CI on Node 18, matching upstream. The lockfile became version 3 when the brighterscript pin was last bumped, and npm 6, which ships with the pinned Node 14, cannot read that format. Every job has failed on it since with "Cannot read property 'fs-extra' of undefined". It went unnoticed because these workflows only run on pull requests and on pushes to master, neither of which has happened on this fork since November. Upstream already runs 18.20.4, so this is picking up a version this fork was left behind on rather than diverging further. Its npm reads the lockfile, and the build, lint and test suites all pass on it. --- .github/workflows/build.yml | 2 +- .github/workflows/create-package.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index db48d9c..77bad2a 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -23,7 +23,7 @@ jobs: - uses: actions/checkout@master - uses: actions/setup-node@master with: - node-version: "14.18.1" + node-version: "18.20.4" architecture: 'x64' # fix for macos-latest registry-url: 'https://npm.pkg.github.com' scope: '@plexinc' diff --git a/.github/workflows/create-package.yml b/.github/workflows/create-package.yml index a5e739f..6be63a3 100644 --- a/.github/workflows/create-package.yml +++ b/.github/workflows/create-package.yml @@ -12,7 +12,7 @@ jobs: - uses: actions/checkout@master - uses: actions/setup-node@master with: - node-version: "14.19.0" + node-version: "18.20.4" registry-url: 'https://npm.pkg.github.com' scope: '@plexinc' # Get a bot token so the bot's name shows up on all our actions