Repository navigation
Commit c60d061
authored
fix(alias): show project aliases with retired template variables migrated (#4690)
`wt config alias show` now displays project aliases with retired
template variables rewritten, matching what the alias actually runs.
Previously a project alias written as `code {{ repo_root }}` showed `{{
repo_root }}`, while execution (via `ProjectConfig::load`) ran the
migrated `{{ repo_path }}` — and user aliases, loaded through
`UserConfig::load`, already showed migrated text, so the two sources
disagreed in one listing.
The cause was `load_project_aliases_silent` parsing `.config/wt.toml`
with a bare `toml::from_str`, on the stated premise that the `aliases`
table has no deprecated forms. The first `DEPRECATION_RULES` row
(`migrate_template_vars_doc`) rewrites retired variables in every string
value, aliases included. The fix runs the file through the same silent
`migrate_content` that `wt config show` and the user-config loader use
before deserializing, and corrects that docstring. The same listing
feeds the `Aliases:` section of `wt --help`, which shows names only, so
only `show` changes visibly.
`test_config_alias_show_migrates_retired_template_vars` configures a
project alias with `{{ repo_root }}` and a user alias with `{{ worktree
}}`; before the fix its snapshot showed `repo_root` for the project
entry, now both show their replacements.
Co-authored-by: worktrunk-bot <254187624+worktrunk-bot@users.noreply.github.com>1 parent ea28955 commit c60d061
3 files changed
Lines changed: 99 additions & 6 deletions
File tree
- src/commands
- tests
- integration_tests
- snapshots
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
885 | 885 | | |
886 | 886 | | |
887 | 887 | | |
888 | | - | |
889 | | - | |
890 | | - | |
| 888 | + | |
| 889 | + | |
| 890 | + | |
| 891 | + | |
891 | 892 | | |
892 | 893 | | |
893 | 894 | | |
894 | 895 | | |
895 | | - | |
| 896 | + | |
896 | 897 | | |
897 | 898 | | |
898 | 899 | | |
| |||
923 | 924 | | |
924 | 925 | | |
925 | 926 | | |
926 | | - | |
| 927 | + | |
927 | 928 | | |
928 | 929 | | |
929 | 930 | | |
| |||
932 | 933 | | |
933 | 934 | | |
934 | 935 | | |
935 | | - | |
| 936 | + | |
| 937 | + | |
936 | 938 | | |
937 | 939 | | |
938 | 940 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1970 | 1970 | | |
1971 | 1971 | | |
1972 | 1972 | | |
| 1973 | + | |
| 1974 | + | |
| 1975 | + | |
| 1976 | + | |
| 1977 | + | |
| 1978 | + | |
| 1979 | + | |
| 1980 | + | |
| 1981 | + | |
| 1982 | + | |
| 1983 | + | |
| 1984 | + | |
| 1985 | + | |
| 1986 | + | |
| 1987 | + | |
| 1988 | + | |
| 1989 | + | |
| 1990 | + | |
| 1991 | + | |
| 1992 | + | |
| 1993 | + | |
| 1994 | + | |
| 1995 | + | |
| 1996 | + | |
| 1997 | + | |
1973 | 1998 | | |
1974 | 1999 | | |
1975 | 2000 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
0 commit comments