From f7fa9d3681592ace0c27da345190ef2be99c7fd2 Mon Sep 17 00:00:00 2001 From: Vaatsalya Srivastava Date: Mon, 19 Oct 2026 13:36:28 +0530 Subject: [PATCH] fix: Delete saved datasets passed to apply via objects_to_delete FeatureStore.apply() ignored SavedDataset objects in objects_to_delete, so 'feast delete ' reported success without removing the dataset from the registry. Signed-off-by: Vaatsalya Srivastava --- sdk/python/feast/feature_store.py | 7 +++++ .../test_local_feature_store.py | 31 ++++++++++++++++++- 2 files changed, 37 insertions(+), 1 deletion(-) diff --git a/sdk/python/feast/feature_store.py b/sdk/python/feast/feature_store.py index 407c7135ec5..2df79b9c7c0 100644 --- a/sdk/python/feast/feature_store.py +++ b/sdk/python/feast/feature_store.py @@ -1852,6 +1852,9 @@ def apply( lvs_to_delete = [ ob for ob in objects_to_delete if isinstance(ob, LabelView) ] + saved_datasets_to_delete = [ + ob for ob in objects_to_delete if isinstance(ob, SavedDataset) + ] for data_source in data_sources_to_delete: self.registry.delete_data_source( @@ -1885,6 +1888,10 @@ def apply( self.registry.delete_validation_reference( validation_references.name, project=self.project, commit=False ) + for saved_dataset in saved_datasets_to_delete: + self.registry.delete_saved_dataset( + saved_dataset.name, project=self.project, commit=False + ) for permission in permissions_to_delete: self.registry.delete_permission( permission.name, project=self.project, commit=False diff --git a/sdk/python/tests/unit/local_feast_tests/test_local_feature_store.py b/sdk/python/tests/unit/local_feast_tests/test_local_feature_store.py index 63f51bcef6e..64872fcd353 100644 --- a/sdk/python/tests/unit/local_feast_tests/test_local_feature_store.py +++ b/sdk/python/tests/unit/local_feast_tests/test_local_feature_store.py @@ -16,7 +16,7 @@ from feast.feature_store import FeatureStore from feast.feature_view import DUMMY_ENTITY_ID, DUMMY_ENTITY_NAME, FeatureView from feast.field import Field -from feast.infra.offline_stores.file_source import FileSource +from feast.infra.offline_stores.file_source import FileSource, SavedDatasetFileStorage from feast.infra.online_stores.dynamodb import DynamoDBOnlineStore from feast.infra.online_stores.sqlite import SqliteOnlineStoreConfig from feast.on_demand_feature_view import OnDemandFeatureView @@ -24,6 +24,7 @@ from feast.permissions.permission import Permission from feast.permissions.policy import RoleBasedPolicy from feast.repo_config import RegistryConfig, RepoConfig +from feast.saved_dataset import SavedDataset from feast.stream_feature_view import stream_feature_view from feast.transformation.pandas_transformation import PandasTransformation from feast.types import Array, Bytes, Float32, Int64, String, ValueType, from_value_type @@ -443,6 +444,34 @@ def test_apply_permissions(test_feature_store): test_feature_store.teardown() +@pytest.mark.parametrize( + "test_feature_store", + [lazy_fixture("feature_store_with_local_registry")], +) +def test_apply_delete_saved_dataset(test_feature_store): + """Test that a saved dataset can be deleted using objects_to_delete with partial=False.""" + assert isinstance(test_feature_store, FeatureStore) + + saved_dataset = SavedDataset( + name="my_saved_dataset", + features=["driver_fv:conv_rate"], + join_keys=["driver_id"], + storage=SavedDatasetFileStorage(path="my_saved_dataset.parquet"), + ) + test_feature_store.registry.apply_saved_dataset( + saved_dataset, test_feature_store.project, commit=True + ) + assert len(test_feature_store.list_saved_datasets()) == 1 + + test_feature_store.apply( + objects=[], objects_to_delete=[saved_dataset], partial=False + ) + + assert test_feature_store.list_saved_datasets() == [] + + test_feature_store.teardown() + + def _apply_feature_view_to_delete(test_feature_store, file_source): """Register an entity and a feature view, and return the feature view.""" entity = Entity(