Skip to content

Commit 16473fe

Browse files
committed
chore: Remove unneeded acquisition team override
1 parent 001c534 commit 16473fe

3 files changed

Lines changed: 6 additions & 8 deletions

File tree

‎.github/workflows/run_action.yaml‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,11 @@ name: Apify Pull Request Toolkit
33
on:
44
# Gives fork runs the secrets to close their issues on merge; safe since no pull request code is checked out.
55
pull_request_target:
6-
types: ['opened', 'reopened', 'synchronize', 'labeled', 'unlabeled', 'edited', 'ready_for_review', 'closed']
6+
# Required workflows from repository rulesets can only run on the default trigger events.
7+
# 'labeled', 'unlabeled', 'edited', 'ready_for_review', 'closed' cannot be handled by this workflow,
8+
# so instead we'll listen to them by webhooks and rerun this workflow when necessary.
9+
types: ['opened', 'reopened', 'synchronize']
10+
711

812
# The action uses only the org token, so `GITHUB_TOKEN` (writable under `pull_request_target`) gets no permissions.
913
permissions: {}

‎src/consts.ts‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,6 @@ export const TEAM_NAME_TO_LABEL: { [name: string]: string } = {
1111
Infrastructure: 't-infra',
1212
};
1313

14-
// Project boards are found by the "<TEAM_NAME> Team Kanban" convention. A team whose board
15-
// carries a different name needs an entry here, or its board is silently not found.
16-
export const TEAM_NAME_TO_PROJECT_TITLE: { [name: string]: string } = {
17-
Web: 'Acquisition Team Kanban',
18-
};
1914
export const PROJECT_FIELD_NAMES = {
2015
ESTIMATE: 'Estimate',
2116
SPRINT: 'Sprint',

‎src/pull_request_toolkit.ts‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import {
66
PRODUCT_ENGINEERING_TEAM_SLUG,
77
TEAM_LABEL_PREFIX,
88
TEAM_NAME_TO_LABEL,
9-
TEAM_NAME_TO_PROJECT_TITLE,
109
} from './consts.ts';
1110
import { UserError } from './errors.ts';
1211
import type { GitHubModel } from './github_model.ts';
@@ -177,7 +176,7 @@ export class PullRequestToolkit {
177176
*/
178177
public async findProjectForTeam(teamName: string) {
179178
const projects = await this.githubModel.listProjects(this.pullRequestRepoOwner);
180-
const projectName = TEAM_NAME_TO_PROJECT_TITLE[teamName] || `${teamName} Team Kanban`;
179+
const projectName = `${teamName} Team Kanban`;
181180
const project = projects.find((p) => p.title === projectName);
182181
if (!project) return null;
183182

0 commit comments

Comments
 (0)