Repository navigation
🐛 Preserve '?' in query and '#' in fragment when appending URL params - #40569
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
appendEncodedParamStringToUrlsplit the URL withurl.split('#', 2)andsplit('?', 2).String.prototype.splitwith a limit drops everything after the limit, so adding a parameter truncated URLs whose query contains?(for example?next=/cart?id=5) or whose fragment contains#(for example#/route#section).This affects every caller of
addParamToUrl,addParamsToUrl, andaddMissingParamsToUrl, including link decoration withdata-amp-addparams, theamp-analyticslinker, and impression tracking.The fix splits on the first
#and the first?withindexOf, keeping the rest of the URL intact. Output for URLs without extra?or#is unchanged.Tests: two new cases in
test/unit/test-url.jscover a?inside the query (append and add-to-front) and a#inside the fragment.Fixes #40568