chore: use shared piece lifespan presets in the shadow virtual tests

Author: justandras

packages/corelib/src/playout/__tests__/infinites.test.ts

@@ -554,10 +554,9 @@ describe('Infinites', () => {
 			const virtualEnder = (id: string, lifespan: IPieceLifespan) =>
 				createPieceInstance({ ...createPiece(`${id}_end`, 'part1', 0, id, lifespan), virtual: true })
 
-			const legacyPersist: IPieceLifespan = { ...rundownPersist, inShadow: 'legacy-persist' }
 			const playing = createPlaying('part1', [
-				continuedAdlib('legacy', legacyPersist),
-				virtualEnder('legacy', legacyPersist),
+				continuedAdlib('legacy', rundownLegacy),
+				virtualEnder('legacy', rundownLegacy),
 				continuedAdlib('persist', rundownPersist),
 				virtualEnder('persist', rundownPersist),
 			])

packages/corelib/src/playout/__tests__/processAndPrune.test.ts

@@ -216,14 +216,9 @@ describe('processAndPrunePieceInstanceTimings', () => {
 				fromPreviousPart: true,
 			})
 		const shadow = (enable: Piece['enable']): PieceInstance => {
-			const instance = createPieceInstance('shadow', enable, 'one', {
-				scope: 'part',
-				presence: 'forward-scope',
-				inShadow: 'stop',
-			})
+			const instance = createPieceInstance('shadow', enable, 'one', partOnlyLifespan)
 			return { ...instance, piece: { ...instance.piece, virtual: true, virtualMode: 'shadow' } }
 		}
-		const rundownPersist: IPieceLifespan = { scope: 'rundown', presence: 'forward-scope', inShadow: 'persist' }
 
 		test('an adlib taken before a shadow stays under it, wherever the playhead is', () => {
 			const adlib = {
@@ -292,7 +287,7 @@ describe('processAndPrunePieceInstanceTimings', () => {
 		test('a legacy-persist piece is cut by a shadow, and resumes after it', () => {
 			const resolvedInstances = runAndTidyResult(
 				[
-					continuation('incoming', { ...rundownPersist, inShadow: 'legacy-persist' }),
+					continuation('incoming', LEGACY_PIECE_LIFESPAN_PRESETS[LegacyPieceLifespan.OutOnRundownEnd]),
 					shadow({ start: 2000, duration: 3000 }),
 				],
 				createPartCurrentTimes(500, 0)
@@ -348,8 +343,7 @@ describe('processAndPrunePieceInstanceTimings', () => {
 
 		test('a clear virtual which does not end a persisting piece obstructs it while active, as a shadow', () => {
 			const clear = createPieceInstance('clear', { start: 2000, duration: 3000 }, 'one', partOnlyLifespan, true)
-			const segmentPersist: IPieceLifespan = { scope: 'segment', presence: 'forward-scope', inShadow: 'persist' }
-			const legacyPersist: IPieceLifespan = { ...rundownPersist, inShadow: 'legacy-persist' }
+			const legacyPersist = LEGACY_PIECE_LIFESPAN_PRESETS[LegacyPieceLifespan.OutOnRundownEnd]
 
 			expect(
 				runAndTidyResult([continuation('incoming', segmentPersist), clear], createPartCurrentTimes(500, 0))

packages/job-worker/src/playout/__tests__/infinitesE2E.test.ts

@@ -24,7 +24,10 @@ import { sleep } from '@sofie-automation/shared-lib/dist/lib/lib'
 import { wrapDefaultObject } from '@sofie-automation/corelib/dist/settings/objectWithOverrides'
 import { IPieceLifespan } from '@sofie-automation/shared-lib/dist/core/model/Rundown'
 import { LegacyPieceLifespan } from '@sofie-automation/blueprints-integration'
-import { LEGACY_PIECE_LIFESPAN_PRESETS } from '@sofie-automation/corelib/dist/playout/pieceLifespan'
+import {
+	DEFAULT_PIECE_LIFESPAN,
+	LEGACY_PIECE_LIFESPAN_PRESETS,
+} from '@sofie-automation/corelib/dist/playout/pieceLifespan'
 import { adjustFakeTime, useFakeCurrentTime } from '../../__mocks__/time.js'
 
 jest.spyOn(peripheralDeviceLib, 'executePeripheralDeviceFunction').mockImplementation(async () => sleep(10))
@@ -297,13 +300,10 @@ describe('Infinites through playout', () => {
 		await take(playlistId)
 
 		for (const layer of ['layerS', 'layerP']) {
-			await insertOnAir(
-				playlistId,
-				`Shadow ${layer}`,
-				{ scope: 'part', presence: 'forward-scope', inShadow: 'stop' },
-				layer,
-				{ enable: { start: 'now', duration: 1000 }, virtualMode: 'shadow' }
-			)
+			await insertOnAir(playlistId, `Shadow ${layer}`, DEFAULT_PIECE_LIFESPAN, layer, {
+				enable: { start: 'now', duration: 1000 },
+				virtualMode: 'shadow',
+			})
 		}
 
 		const shadows = (await context.mockCollections.PieceInstances.findFetch()).filter((p) =>