Skip to content

ability icons snap if skipping during upgrade [bounty: 7 XTR] #2016

Description

@DreadKnight

The smooth transition animation of ability icon gets disabled somehow when skipping turn during the ability upgrade animation (upgrade icon over the ability icon), causing the icon to snap in and out instantly next times depending if the ability is usable.

Activity

  1. added
    codingThis issue requires some programming
    visualsVarious things that easily catch the eye
    abilitiesThe issue is related to an unit ability or more
    on Jan 30, 2022
  2. added this to the 0.5 - Chimera milestone on Jan 30, 2022
  3. added
    bountySome amount of our token, XatteR, is offered
    on Jan 30, 2022
  4. added a commit that references this issue on Jan 30, 2022
  5. changed the title [-]icons of ultimate abilities snap after upgrade [bounty: 5 XatteR][/-] [+]icons of abilities snap after upgrade [bounty: 5 XatteR][/+] on Jan 30, 2022
  6. pinned this issue on Jan 30, 2022
  7. changed the title [-]icons of abilities snap after upgrade [bounty: 5 XatteR][/-] [+]ability icons start snapping if skipping turn during their upgrade event [bounty: 5 XatteR][/+] on Jan 30, 2022
  8. changed the title [-]ability icons start snapping if skipping turn during their upgrade event [bounty: 5 XatteR][/-] [+]ability icons snap if skipping during their upgrade event [bounty: 5 XatteR][/+] on Jan 30, 2022
  9. changed the title [-]ability icons snap if skipping during their upgrade event [bounty: 5 XatteR][/-] [+]ability icons snap if skipping during their upgrade [bounty: 5 XatteR][/+] on Jan 30, 2022
  10. changed the title [-]ability icons snap if skipping during their upgrade [bounty: 5 XatteR][/-] [+]ability icons snap if skipping when upgraded [bounty: 5 XatteR][/+] on Jan 30, 2022
  11. 9 remaining items

  12. changed the title [-]ability icons snap if skipping during upgrade [bounty: 30 XTR][/-] [+]ability icons snap if skipping during upgrade [bounty: 14 XTR][/+] on Oct 24, 2022
  13. changed the title [-]ability icons snap if skipping during upgrade [bounty: 14 XTR][/-] [+]ability icons snap if skipping during upgrade [bounty: 7 XTR][/+] on Nov 17, 2022
  14. added a commit that references this issue on Apr 20, 2023
  15. sungdark commented on Mar 27, 2026

    @sungdark

    我来认领此赏金任务!

    收款地址:eB51DWp1uECrLZRLsE2cnyZUzfRWvzUzaJzkatTpQV9

    我会修复这个能力图标在跳过回合时卡片的平滑过渡动画被禁用的问题。

  16. added a commit that references this issue on Mar 27, 2026
    f539b7d
  17. sungdark commented on Mar 27, 2026

    @sungdark

    PR submitted: #2904

    修复说明:当在能力升级动画期间跳过回合时,之前只清除了1500ms的超时计时器,而300ms(音效)和1200ms(移除upgradeIcon)的计时器仍会在回合切换后触发,导致按钮状态不一致。

    修复方案:

    • 将所有三个升级动画超时ID存储为类属性
    • 在触发skipTurn时清除所有升级超时
    • 立即从所有能力按钮中移除 upgradeTransition 和 upgradeIcon 类,确保下一个回合状态干净

    收款地址:eB51DWp1uECrLZRLsE2cnyZUzfRWvzUzaJzkatTpQV9

  18. zhaog100 commented on Mar 27, 2026

    @zhaog100

    /attempt

  19. roxonn-contribution-rewards commented on Mar 27, 2026

    @roxonn-contribution-rewards

    👤 @zhaog100 is now working on this issue!

    Started: Fri, 27 Mar 2026 09:30:08 GMT

    Next steps:

    1. Create a Pull Request when ready
    2. Include fixes #2016 in PR description
    3. Add a bounty to this issue: /bounty <amount> <currency>

    Other contributors: Please coordinate in comments or work on different issues.


    Powered by Roxonn

  20. domfelipe commented on Oct 31, 2026

    @domfelipe

    Hi, I'd like to work on this bounty please. My plan: track all three upgrade-animation timeouts (300ms sound, 1200ms icon swap, 1500ms transition end) instead of only the last one, and cancel them plus strip the half-applied classes whenever the turn changes mid-animation (skip/delay/panel swap). MintMe wallet for the bounty: 0x9f135aeb40e7b26a72aa730cf6ebb241c6b8813a

  21. domfelipe commented on Oct 31, 2026

    @domfelipe

    PR opened with the fix: #3237 — tracks and cancels all three upgrade-animation timeouts on skip/delay/panel swap, with a Jest regression suite. bun run build + bunx eslint + scoped bunx jest all pass on the branch. MintMe wallet: 0x9f135aeb40e7b26a72aa730cf6ebb241c6b8813a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    abilitiesThe issue is related to an unit ability or morebountySome amount of our token, XatteR, is offeredcodingThis issue requires some programmingvisualsVarious things that easily catch the eye

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions